Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IJ Plugin] Play nice with IDEs without Kotlin/Gradle #6358

Merged
merged 3 commits into from
Jan 20, 2025

Conversation

BoD
Copy link
Contributor

@BoD BoD commented Jan 20, 2025

Some inspections were running (and trying to load Kotlin specific classes) even when in IDEs without the Kotlin plugin - e.g. RustRover. This could break the whole language support.

In general this PR makes things smoother in IDEs other than IJ/AS:

  • Make inspections run only with specific file types
  • Move all components specific to Apollo Kotlin to the Kotlin plugin dependency file
  • Do not load services that can't work without the Kotlin and Gradle plugins
  • Hide settings that are irrelevant without the Kotlin and Gradle plugins
  • Mark the Gradle plugin as optional

@BoD BoD requested a review from martinbonnin as a code owner January 20, 2025 15:33
@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented Jan 20, 2025

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: 46a767eb0fc68fe423462f16

@BoD BoD merged commit 7e8570f into main Jan 20, 2025
7 checks passed
@BoD BoD deleted the intellij-plugin-fix-inspections branch January 20, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants